Updated auto approve example to minimizing notifications #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
reviewed
Mar 29, 2022
| if [ "$(gh pr status --json reviewDecision -q .currentBranch.reviewDecision)" != "APPROVED" ]; | ||
| then gh pr review --approve "$PR_URL" | ||
| else echo "PR already approved, skipping additional approvals to minimize emails/notification noise."; | ||
| fi |
There was a problem hiding this comment.
I think there might be a way to avoid the need for the checkout by passing in the right event property to actions/checkout to get the ref rather than the detached head state.
I'm travelling at the moment so I haven't been able to carve out time to verify this, but this is better than it was so I'm 👍🏻 on merging this.
brrygrdn
approved these changes
Mar 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138